Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopped monitoring threads #718

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix stopped monitoring threads #718

merged 2 commits into from
Nov 16, 2023

Conversation

sergiyvamz
Copy link
Contributor

Summary

Fix stopped monitoring threads

Description

  • Improve exception logging in monitoring thread
  • Increase monitoring thread idle time to 10min
  • Make sure getting an existing monitor, creating a new monitor, and destroying a monitor are well-synchronized.
  • Avoid caching a reference to monitor object since it may be destroyed; use weak pointer instead.
  • Avoid storing and then reusing of idle/stopped monitors

Additional Reviewers

@karenc-bq
@aaron-congo
@crystall-bitquill
@aaronchung-bitquill

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergiyvamz sergiyvamz changed the title [WIP] Fix stopped monitoring threads Fix stopped monitoring threads Nov 2, 2023
@crystall-bitquill crystall-bitquill enabled auto-merge (squash) November 16, 2023 22:03
@crystall-bitquill crystall-bitquill merged commit 2f8f5ca into main Nov 16, 2023
5 checks passed
@sergiyvamz sergiyvamz deleted the efm-stopped-thread branch November 16, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants