fix: autoscaling tests #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
commented
Nov 16, 2024
Comment on lines
+5
to
+7
| push: | ||
| branch: | ||
| - test/autoscaling |
There was a problem hiding this comment.
Will remove before merge
karenc-bq
commented
Nov 16, 2024
| const totalInstances: number = await auroraTestUtility.getNumberOfInstances(); | ||
| const instances: TestInstanceInfo[] = env.databaseInfo.instances; | ||
| const numInstances: number = instances.length; | ||
| it.only("set read only on old connection", async () => { |
There was a problem hiding this comment.
Will change this back to itIf before merge
There was a problem hiding this comment.
I think it should be itIfMinimumFiveInstances instead of itIf
karenc-bq
force-pushed
the
test/autoscaling
branch
from
d8a23dc
to
b277a7e
Compare
crystall-bitquill
approved these changes
Nov 16, 2024
joyc-bq
approved these changes
Nov 16, 2024
karenc-bq
force-pushed
the
test/autoscaling
branch
from
3906492
to
a7b367d
Compare
Co-authored-by: crystall-bitquill <97126568+crystall-bitquill@users.noreply.github.com>
karenc-bq
force-pushed
the
test/autoscaling
branch
from
ec4f7ee
to
2f2a80f
Compare
karenc-bq
force-pushed
the
test/autoscaling
branch
from
2f2a80f
to
c0208a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.