Implement Benchmarks #254
Merged
Implement Benchmarks #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add the benchmarking results to the documentation as well? |
karenc-bq
reviewed
Oct 31, 2023
| @@ -73,35 +73,66 @@ | |||
|
|
|||
| logger = Logger(__name__) | |||
|
|
|||
| _profiles: Dict[str, List[PluginFactory]] = {} | |||
There was a problem hiding this comment.
There is PR that updates the plugin profiles on the JDBC Wrapper. The existing plugin profile implementation also isn't widely used as seen on the JDBC side. What do you think if we add the plugin profile feature later?
congoamz
reviewed
Oct 31, 2023
Comment on lines
111
to
112
| if contains_profile(profile_name): | ||
| plugin_factories = get_plugin_factories(profile_name) |
There was a problem hiding this comment.
nit:
Suggested change
| if contains_profile(profile_name): | |
| plugin_factories = get_plugin_factories(profile_name) | |
| plugin_factories = get_plugin_factories(profile_name) |
There was a problem hiding this comment.
Oops. Surprised I didn't catch this myself. Thanks for pointing it out.
| @@ -73,35 +73,66 @@ | |||
|
|
|||
| logger = Logger(__name__) | |||
|
|
|||
| _profiles: Dict[str, List[PluginFactory]] = {} | |||
There was a problem hiding this comment.
Does this PR also fully implement driver configuration profiles? If so, should we add docs for driver profiles? Could also be done in a separate PR
justing-bq
force-pushed
the
benchmarks
branch
from
f83ff98 to
a067aa0
Compare
karenc-bq
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Benchmarks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.