Updated eks-distro-minimal-base image #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suniltheta
reviewed
Oct 29, 2021
There was a problem hiding this comment.
Why not use the latest tag public.ecr.aws/eks-distro-build-tooling/eks-distro-minimal-base:latest, since that latest tag is available now? I know we would want to be sure that we test our changes against a fixed version, but since this is the base of controller image itself, we are sure that everytime we do a release we will be throughly testing it anyway.
This also saves us from needing to keep this tag updated.
This is similar to how to rely on public.ecr.aws/amazonlinux/amazonlinux:2 link to just work and we always base on the docker image tag "2".
Agreed. In this case the released controller image will be tested and won't be rebuild again so customers would have same base layer in the released image. Will update it to latest tag |
suniltheta
approved these changes
Oct 29, 2021
suniltheta
approved these changes
Oct 29, 2021
achevuru
reviewed
Oct 29, 2021
Use latest tag for base image use fixed image tag
cgchinmay
force-pushed
the
update_eks_distro_base
branch
from
abbe59d
to
440cb4e
Compare
achevuru
approved these changes
Oct 29, 2021
cgchinmay
added a commit
to cgchinmay/aws-app-mesh-controller-for-k8s
that referenced
this pull request
Nov 19, 2021
Xray SamplingRate changes Add service instance port to Cloud Map Service Discovery (aws#490) Volume injection support (aws#488) Introduce config variables for samplingRate & statsSocketPath (aws#512) Use xray daemon from ecr public repo instead of dockerhub update envoy image to 1.19.1.1-prod Updated proxy-route-manager to v4-prod Updated Dockerfile to support multi-arch Updated Makefile to use docker buildx Updated go version
cgchinmay
added a commit
to cgchinmay/aws-app-mesh-controller-for-k8s
that referenced
this pull request
Nov 19, 2021
Xray SamplingRate changes Add service instance port to Cloud Map Service Discovery (aws#490) Volume injection support (aws#488) Introduce config variables for samplingRate & statsSocketPath (aws#512) Use xray daemon from ecr public repo instead of dockerhub update envoy image to 1.19.1.1-prod Updated proxy-route-manager to v4-prod Updated Dockerfile to support multi-arch Updated Makefile to use docker buildx Updated go version Updated spire agent and server to 0.12.0 to be compatible with envoy v1.19.x Dockerfile changes to support ARM
cgchinmay
added a commit
to cgchinmay/aws-app-mesh-controller-for-k8s
that referenced
this pull request
Nov 29, 2021
Xray SamplingRate changes Add service instance port to Cloud Map Service Discovery (aws#490) Volume injection support (aws#488) Introduce config variables for samplingRate & statsSocketPath (aws#512) Use xray daemon from ecr public repo instead of dockerhub update envoy image to 1.19.1.1-prod Updated proxy-route-manager to v4-prod Updated Dockerfile to support multi-arch Updated Makefile to use docker buildx Updated go version Updated spire agent and server to 0.12.0 to be compatible with envoy v1.19.x Dockerfile changes to support ARM Bump Envoy image version to v1.20.0.1-prod (aws#538) Co-authored-by: Shailesh Gupta <sshgup@amazon.com>
cgchinmay
added a commit
that referenced
this pull request
Dec 2, 2021
Xray SamplingRate changes Add service instance port to Cloud Map Service Discovery (#490) Volume injection support (#488) Introduce config variables for samplingRate & statsSocketPath (#512) Use xray daemon from ecr public repo instead of dockerhub Updated proxy-route-manager to v4-prod Updated Dockerfile to support multi-arch Updated Makefile to use docker buildx Updated go version Updated spire agent and server to 0.12.0 to be compatible with envoy v1.19.x Dockerfile changes to support ARM Bump Envoy image version to v1.20.0.1-prod (#538) Co-authored-by: Shailesh Gupta <sshgup@amazon.com> Update Chart and App version for new patch release
cgchinmay
added a commit
that referenced
this pull request
Mar 24, 2022
* Fixes for v1.4.1 patch release reverts default envoy image version to 1.16 (#494) Used EKS-D minimal non root as the base image instead of amazonlinux:2 (#501) Co-authored-by: Chinmay Gadgil <cgadgil@amazon.com> Use root image of minimal EKD-D to read service account token (#502) Fix for failing UT Updating unit-test.yml file to fix kubebuilder issue Co-authored-by: Chinmay Gadgil <cgadgil@amazon.com> Remove field length constraints from query parameter exact match criteria (#487) Updated Chart minor version Updated CRD field constraints for queryparameters Co-authored-by: Chinmay Gadgil <cgadgil@amazon.com> HTTPQueryParam CRD Description update CRD QueryParameter description update Update helm to use v1.4.1 of the appmesh-controller helm update * Updated eks-distro-minimal-base image (#527) Xray SamplingRate changes Add service instance port to Cloud Map Service Discovery (#490) Volume injection support (#488) Introduce config variables for samplingRate & statsSocketPath (#512) Use xray daemon from ecr public repo instead of dockerhub Updated proxy-route-manager to v4-prod Updated Dockerfile to support multi-arch Updated Makefile to use docker buildx Updated go version Updated spire agent and server to 0.12.0 to be compatible with envoy v1.19.x Dockerfile changes to support ARM Bump Envoy image version to v1.20.0.1-prod (#538) Co-authored-by: Shailesh Gupta <sshgup@amazon.com> Update Chart and App version for new patch release * Update api extensions to v1 * Add preserveUnknownFields to CRDs * Bump CRD patches to apiextensions v1 * Fix CRDs to match release-1.4 * Revert "Fix CRDs to match release-1.4" This reverts commit 7e3c58f. Co-authored-by: Rex Chang <58710378+rexnp@users.noreply.github.com> Co-authored-by: cgchinmay <cgadgil@amazon.com> Co-authored-by: Sebastien Allamand <sallaman@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Use the latest eks-distro-minimal-base image
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.