Add File Based TLS Demo #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 14, 2020 11:08
…nd made some readme changes
…ates directly in the envoy image
bcelenza
reviewed
Jan 17, 2020
walkthroughs/howto-tls-file-provided/infrastructure/ecr-repositories.yaml
Outdated
Show resolved
Hide resolved
walkthroughs/howto-tls-file-provided/src/customEnvoyImage/Dockerfile
Outdated
Show resolved
Hide resolved
walkthroughs/howto-tls-file-provided/src/customEnvoyImage/Dockerfile
Outdated
Show resolved
Hide resolved
bcelenza
reviewed
Jan 17, 2020
| @@ -210,7 +211,6 @@ main() { | |||
| delete_mesh | |||
| ;; | |||
| addGreen) | |||
| create_vnode "${TEST_MESH_DIR}/colorTellerGreen/colorteller-green-vn.json" "colorteller-green-vn" "colorteller-green" | |||
| update_route "${TEST_MESH_DIR}/colorTellerGreen/colorteller-updated-route.json" "colorteller-vr" "colorteller-route" | |||
There was a problem hiding this comment.
Case sensitivity issue is still present on this line.
|
LGTM overall, just one remaining issue. |
bcelenza
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-app-mesh-roadmap#38
Description of changes:
This adds a walkthrough of using File Based TLS with App Mesh.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.