fix(toolkit-lib): "refactor" never releases reader lock or cleans up temp dir (#700)

rix0rrr · web-flow · commit 468b838db8a9 · 2025-07-10T07:21:14.000Z
The refactor operation was not using `await using` on the assembly that
it got from `assemblyFromSource`, causing it to never be cleaned up.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
diff --git a/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts b/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts
@@ -1062,8 +1062,8 @@ export class Toolkit extends CloudAssemblySourceBuilder {
     this.requireUnstableFeature('refactor');
 
     const ioHelper = asIoHelper(this.ioHost, 'refactor');
-    const assembly = await assemblyFromSource(ioHelper, cx);
-    return this._refactor(assembly, ioHelper, options);
+    await using assembly = await assemblyFromSource(ioHelper, cx);
+    return await this._refactor(assembly, ioHelper, options);
   }
 
   private async _refactor(assembly: StackAssembly, ioHelper: IoHelper, options: RefactorOptions = {}): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -1062,8 +1062,8 @@ export class Toolkit extends CloudAssemblySourceBuilder {`
`1062`	`1062`	`this.requireUnstableFeature('refactor');`
`1063`	`1063`
`1064`	`1064`	`const ioHelper = asIoHelper(this.ioHost, 'refactor');`
`1065`		`- const assembly = await assemblyFromSource(ioHelper, cx);`
`1066`		`- return this._refactor(assembly, ioHelper, options);`
	`1065`	`+ await using assembly = await assemblyFromSource(ioHelper, cx);`
	`1066`	`+ return await this._refactor(assembly, ioHelper, options);`
`1067`	`1067`	`}`
`1068`	`1068`
`1069`	`1069`	`private async _refactor(assembly: StackAssembly, ioHelper: IoHelper, options: RefactorOptions = {}): Promise<void> {`