Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 9, 2025

The refactor operation was not using await using on the assembly that it got from assemblyFromSource, causing it to never be cleaned up.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The refactor operation was not using `await using` on the assembly
that it got from `assemblyFromSource`, causing it to never be cleaned
up.
@rix0rrr rix0rrr requested a review from a team July 9, 2025 13:01
@rix0rrr rix0rrr temporarily deployed to integ-approval July 9, 2025 13:01 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team July 9, 2025 13:01
@github-actions github-actions bot added the p2 label Jul 9, 2025
@rix0rrr rix0rrr changed the title fix(toolkit-lib): reader lock is leaked for refactor fix(toolkit-lib): "refactor" never releases reader lock or cleans up temp dir Jul 9, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (90579c3) to head (6e5c6ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #700   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files          49       49           
  Lines        7358     7358           
  Branches      817      818    +1     
=======================================
  Hits         5843     5843           
  Misses       1496     1496           
  Partials       19       19           
Flag Coverage Δ
suite.unit 79.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 468b838 Jul 10, 2025
37 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/cleanup-refactor branch July 10, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants