Skip to content

Commit e4c1f15

Browse files
authored
chore(cli-integ): node-gyp fails on newer python versions (#407)
The `cli-integ` tests depend on the `node-pty` package for testing of interactive terminals. This package needs to be build at install time using `node-gyp`. Because previously `cli-integ` tests dependet on an old version of `npm`, we got an old version of `node-gyp` which is incomaptible with recent python versions. To fix this, we upgrade the dependency to a more recent version of `npm`. Fixes failing Python package release. Proof this fix works: https://github.com/aws/aws-cdk-cli/actions/runs/14619849549/job/41016752989?pr=406 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent cd4ec06 commit e4c1f15

File tree

4 files changed

+783
-787
lines changed

4 files changed

+783
-787
lines changed

.projenrc.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1686,7 +1686,7 @@ const cliInteg = configureProject(
16861686
'glob@^7',
16871687
'make-runnable@^1',
16881688
'mockttp@^3',
1689-
'npm@^8',
1689+
'npm@^10',
16901690
'p-queue@^6',
16911691
'semver@^7',
16921692
'sinon@^9',

packages/@aws-cdk-testing/cli-integ/.projen/deps.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/cli-integ/package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)