chore(cli-integ): node-gyp fails on newer python versions #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Apr 23, 2025
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/chore/fix-python-build
branch
from
1cb693b to
1cb634a
Compare
aws-cdk-automation
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
The `cli-integ` tests depend on the `node-pty` package for testing of interactive terminals. This package needs to be build at install time using `node-gyp`. Because previously `cli-integ` tests dependet on an old version of `npm`, we got an old version of `node-gyp` which is incomaptible with recent python versions. To fix this, we upgrade the dependency to a more recent version of `npm`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 80.94% 81.04% +0.10%
==========================================
Files 66 66
Lines 6879 6879
Branches 791 796 +5
==========================================
+ Hits 5568 5575 +7
+ Misses 1291 1283 -8
- Partials 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
force-pushed
the
mrgrain/chore/fix-python-build
branch
from
046747d to
702018c
Compare
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
auto-merge was automatically disabled
April 23, 2025 14:27
Pull request was closed
|
Total lines changed 1570 is greater than 1000. Please consider breaking this PR down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cli-integtests depend on thenode-ptypackage for testing of interactive terminals. This package needs to be build at install time usingnode-gyp. Because previouslycli-integtests dependet on an old version ofnpm, we got an old version ofnode-gypwhich is incomaptible with recent python versions.To fix this, we upgrade the dependency to a more recent version of
npm.Fixes failing Python package release.
Proof this fix works: https://github.com/aws/aws-cdk-cli/actions/runs/14619849549/job/41016752989?pr=406
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license