chore: enforce consistent-type-imports everywhere #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 85.09% 85.00% -0.09%
==========================================
Files 208 208
Lines 35600 35680 +80
Branches 4640 4627 -13
==========================================
+ Hits 30295 30331 +36
- Misses 5153 5199 +46
+ Partials 152 150 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
force-pushed
the
mrgrain/chore/consistent-type-imports
branch
from
4a1fad4 to
081e265
Compare
mrgrain
force-pushed
the
mrgrain/chore/consistent-type-imports
branch
from
081e265 to
0d9e8a5
Compare
mrgrain
force-pushed
the
mrgrain/chore/consistent-type-imports
branch
from
0d9e8a5 to
1edc2e2
Compare
kaizencc
reviewed
Mar 13, 2025
| disabledEsLintRules: [EsLintRules.MAX_LEN], // the default disabled rules result in 'Definition for rule 'prettier/prettier' was not found' | ||
| disabledEsLintRules: [ | ||
| EsLintRules.MAX_LEN, // the default disabled rules result in 'Definition for rule 'prettier/prettier' was not found | ||
| '@typescript-eslint/consistent-type-imports', // (ironically) typewriter does not support type imports |
Contributor
There was a problem hiding this comment.
dang who wrote typewriter?
kaizencc
approved these changes
Mar 13, 2025
Signed-off-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already enforcing this rule in
toolkit-lib. Let's enforce it everywhere.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license