-
Notifications
You must be signed in to change notification settings - Fork 61
fix(cli): hotswap is reporting and running changes that don't happen #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| readonly resourceType: string; | ||
| readonly propsChanged: Array<string>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly, these were unused. propsChanged is not made available as raw data via change.
| /** | ||
| * Represents a change that can be hotswapped. | ||
| */ | ||
| export class HotswappableChangeCandidate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a class, but was never used as one. It's now an interface as it should be.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 85.09% 85.10%
=======================================
Files 206 206
Lines 35215 35197 -18
Branches 4535 4534 -1
=======================================
- Hits 29966 29954 -12
+ Misses 5099 5095 -4
+ Partials 150 148 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| logicalId: string; | ||
| resourceType: string; | ||
| physicalName?: string; | ||
| description: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅 This would be nicer with a named struct definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming up next!
|
Bypassing tests due to unrelated test failure. |
This change is three fold:
HotswapOperationinterface (néeHotswappableChange) by removing two unused fields and adding in a new filed in preparation for structured data alongside hotswap messageslambda-functions.tsdon't report hotswappable changes for versions and aliases. These used to be reported with an empty array forresourceNamesand a noopapplyfunction. This means that literally nothing happens with these entries, sinceapplydoesn't do anything and the CLI usesresourceNamesto print anything. Just removing these as they are reported as part of a change to the function.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license