generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 61
fix(cli): hotswap output is different for different resources #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 84.98% 85.19% +0.20%
==========================================
Files 218 218
Lines 36476 36517 +41
Branches 4563 4575 +12
==========================================
+ Hits 31000 31111 +111
+ Misses 5332 5261 -71
- Partials 144 145 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f62f0de to
8627b14
Compare
iliapolo
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns hotswap output to always follow the pattern:
<CfnResourceType>: '<physical name>'For example:
Previously we used "friendly" type names for some resources, but not all.
Custom descriptions are kept only for more complicated resources, e.g.:
Arguably this reduces output fidelity to hotswap users, however it increases consistency and maintainability.
Also attaches more information to each affected resources, opening up potential future changes and structured data interfaces. This completes the cleanup on the
hotswappableChangesside. Next up is thenonHotswappableChanges.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license