Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 18, 2025

Aligns hotswap output to always follow the pattern: <CfnResourceType>: '<physical name>'
For example:

AWS::Lambda::Function 'my-func'
AWS::CodeBuild::Project 'my-project'

Previously we used "friendly" type names for some resources, but not all.
Custom descriptions are kept only for more complicated resources, e.g.:

Contents of AWS::S3::Bucket 'my-bucket'
AWS::Lambda::Alias 'my-alias' for AWS::Lambda::Function 'my-func'

Arguably this reduces output fidelity to hotswap users, however it increases consistency and maintainability.


Also attaches more information to each affected resources, opening up potential future changes and structured data interfaces. This completes the cleanup on the hotswappableChanges side. Next up is the nonHotswappableChanges.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval March 18, 2025 16:45 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team March 18, 2025 16:45
@github-actions github-actions bot added the p2 label Mar 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.19%. Comparing base (be378de) to head (8627b14).

Files with missing lines Patch % Lines
...aws-cdk/lib/api/deployments/hotswap-deployments.ts 92.85% 1 Missing ⚠️
...dk/lib/api/hotswap/stepfunctions-state-machines.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   84.98%   85.19%   +0.20%     
==========================================
  Files         218      218              
  Lines       36476    36517      +41     
  Branches     4563     4575      +12     
==========================================
+ Hits        31000    31111     +111     
+ Misses       5332     5261      -71     
- Partials      144      145       +1     
Flag Coverage Δ
suite.unit 85.19% <97.33%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain temporarily deployed to integ-approval March 18, 2025 18:33 — with GitHub Actions Inactive
@mrgrain mrgrain force-pushed the mrgrain/feat/hotswapple-changes branch from f62f0de to 8627b14 Compare March 19, 2025 09:36
@mrgrain mrgrain temporarily deployed to integ-approval March 19, 2025 09:36 — with GitHub Actions Inactive
@mrgrain mrgrain added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit db4029c Mar 19, 2025
20 checks passed
@mrgrain mrgrain deleted the mrgrain/feat/hotswapple-changes branch March 19, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants