Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 19, 2025

Adds structured data to hotswap messages. Includes a new trace method that contains information about the hotswap after details have been computed, but before execution.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval March 19, 2025 15:36 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 15:36
@github-actions github-actions bot added the p2 label Mar 19, 2025
@mrgrain mrgrain changed the base branch from main to mrgrain/feat/non-hotswappable-resources March 19, 2025 15:37
@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-resources branch from 4ec1228 to 65e0c40 Compare March 19, 2025 15:38
@mrgrain mrgrain force-pushed the mrgrain/feat/report-hotswap-messages branch 3 times, most recently from c186451 to 993f924 Compare March 19, 2025 16:11
@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-resources branch from 65e0c40 to 0ef8307 Compare March 19, 2025 20:48
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 19, 2025
@mrgrain mrgrain force-pushed the mrgrain/feat/report-hotswap-messages branch from 993f924 to 369b82e Compare March 19, 2025 20:49
Base automatically changed from mrgrain/feat/non-hotswappable-resources to main March 20, 2025 10:14
@mrgrain mrgrain force-pushed the mrgrain/feat/report-hotswap-messages branch from 369b82e to 11fa510 Compare March 20, 2025 10:18
@mrgrain mrgrain marked this pull request as ready for review March 20, 2025 10:19
@mrgrain mrgrain force-pushed the mrgrain/feat/report-hotswap-messages branch from 11fa510 to f2ed455 Compare March 20, 2025 10:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (a3b405a) to head (864bf04).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   85.00%   85.05%   +0.04%     
==========================================
  Files         218      218              
  Lines       36560    36585      +25     
  Branches     4569     4580      +11     
==========================================
+ Hits        31079    31116      +37     
+ Misses       5337     5320      -17     
- Partials      144      149       +5     
Flag Coverage Δ
suite.unit 85.05% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iliapolo iliapolo disabled auto-merge March 20, 2025 10:38
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
@mrgrain mrgrain enabled auto-merge March 20, 2025 10:43
@mrgrain mrgrain added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 30a2a29 Mar 20, 2025
11 checks passed
@mrgrain mrgrain deleted the mrgrain/feat/report-hotswap-messages branch March 20, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants