refactor(cli): settings doesn't log anymore #267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes logging from the
Settingsclass. Logging was only used when loading settings from a file and that functionality is currently only used by theUserConfigurationclass of the CLI. So I localized the loading there. If we wanted to re-introduce a generic loading from file in the future, we just need to build it with theIoHostin mind.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license