Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 20, 2025

Removes logging from the Settings class. Logging was only used when loading settings from a file and that functionality is currently only used by the UserConfiguration class of the CLI. So I localized the loading there. If we wanted to re-introduce a generic loading from file in the future, we just need to build it with the IoHost in mind.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 20, 2025 12:20
@github-actions github-actions bot added the p2 label Mar 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (68b0725) to head (72accdc).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/user-configuration.ts 77.41% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   85.29%   85.12%   -0.17%     
==========================================
  Files         220      220              
  Lines       36619    36627       +8     
  Branches     4458     4437      -21     
==========================================
- Hits        31234    31179      -55     
- Misses       5288     5352      +64     
+ Partials       97       96       -1     
Flag Coverage Δ
suite.unit 85.12% <77.41%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain disabled auto-merge March 20, 2025 13:30
@mrgrain mrgrain force-pushed the mrgrain/refactor/settings-no-logging branch from a16b9e7 to a64858d Compare March 20, 2025 15:08
@mrgrain mrgrain force-pushed the mrgrain/refactor/settings-no-logging branch from a64858d to f0279c8 Compare March 20, 2025 17:01
@mrgrain mrgrain temporarily deployed to integ-approval March 20, 2025 19:00 — with GitHub Actions Inactive
@mrgrain mrgrain added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit a15e73e Mar 20, 2025
20 checks passed
@mrgrain mrgrain deleted the mrgrain/refactor/settings-no-logging branch March 20, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants