-
Notifications
You must be signed in to change notification settings - Fork 61
refactor(cli): new internal cloudformation api module #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): new internal cloudformation api module #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a collection of helpers that were previously in api/deployments but in reality were used across multiple modules that don't have anything to do with deployments.
de528d2 to
8e89503
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 85.24% 85.44% +0.19%
==========================================
Files 219 221 +2
Lines 36499 36512 +13
Branches 4440 4464 +24
==========================================
+ Hits 31115 31198 +83
+ Misses 5287 5216 -71
- Partials 97 98 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e89503 to
966b224
Compare
Pulls some shared "cloudformation" helpers into a new internal api module. This resolves some annoying inter-dependencies between internal modules and specifically breaks up the
deploymentmega module a bit.Also moves some other files from
api/utilso that it's now almost gone (which is the goal).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license