Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 20, 2025

Pulls some shared "cloudformation" helpers into a new internal api module. This resolves some annoying inter-dependencies between internal modules and specifically breaks up the deployment mega module a bit.

Also moves some other files from api/util so that it's now almost gone (which is the goal).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 20, 2025 17:36
@github-actions github-actions bot added the p2 label Mar 20, 2025
Copy link
Contributor Author

@mrgrain mrgrain Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a collection of helpers that were previously in api/deployments but in reality were used across multiple modules that don't have anything to do with deployments.

@mrgrain mrgrain force-pushed the mrgrain/refactor/cloudformation-module branch from de528d2 to 8e89503 Compare March 20, 2025 19:01
@mrgrain mrgrain temporarily deployed to integ-approval March 20, 2025 19:01 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 92.88256% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (0d7bcca) to head (966b224).

Files with missing lines Patch % Lines
...es/aws-cdk/lib/api/cloudformation/stack-helpers.ts 93.12% 13 Missing ⚠️
.../lib/api/cloudformation/template-body-parameter.ts 50.00% 6 Missing ⚠️
packages/aws-cdk/lib/api/deployments/cfn-api.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   85.24%   85.44%   +0.19%     
==========================================
  Files         219      221       +2     
  Lines       36499    36512      +13     
  Branches     4440     4464      +24     
==========================================
+ Hits        31115    31198      +83     
+ Misses       5287     5216      -71     
- Partials       97       98       +1     
Flag Coverage Δ
suite.unit 85.44% <92.88%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit ee0d87d Mar 21, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/cloudformation-module branch March 21, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants