Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 2, 2025

Replaces the current default IoHost which is the same as the one used by the CLI with a strictly non-interactive version. This is more in accordance with the goals of a library providing actions.

Fixes #157
Closes #289

BREAKING CHANGE: This change updates the default IoHost implementation used by Toolkit to a version that is strictly non-interactive, i.e. there is no expectation anymore that users will respond to command-line prompts. To restore previous behavior, you will can provide a custom IoHost implementation to your Toolkit instance. You may consider extending the new NonInteractiveIoHost class with desired interactive prompts.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p1 label Apr 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 2, 2025 10:41
@mrgrain mrgrain force-pushed the mrgrain/toolkit-lib/non-interactive-io-host branch from a06a9c1 to 9fc4434 Compare April 3, 2025 08:38
@mrgrain mrgrain force-pushed the mrgrain/toolkit-lib/non-interactive-io-host branch from 9fc4434 to 4025381 Compare April 3, 2025 09:43
@mrgrain mrgrain temporarily deployed to integ-approval April 3, 2025 09:43 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (3e8359c) to head (62c3dd3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   85.58%   85.49%   -0.09%     
==========================================
  Files         223      223              
  Lines       37002    37002              
  Branches     4493     4500       +7     
==========================================
- Hits        31668    31636      -32     
- Misses       5233     5269      +36     
+ Partials      101       97       -4     
Flag Coverage Δ
suite.unit 85.49% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Apr 3, 2025
@mrgrain mrgrain closed this Apr 3, 2025
@mrgrain mrgrain reopened this Apr 3, 2025
@mrgrain
Copy link
Contributor Author

mrgrain commented Apr 3, 2025

exempted integ test because a previous run passed and the latest change just fixed a comment

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit e0f9a6f Apr 3, 2025
25 of 26 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/toolkit-lib/non-interactive-io-host branch April 3, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NonInteractiveIoHost @aws-cdk/toolkit-lib: unable to destroy stack without custom ioHost

4 participants