Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 3, 2025

Enable using the new Toolkit class from toolki-lib, inside the "old" CdkToolkit used by the CLI.

This will allow us to have new features be only implemented once with a thing pass through layer.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 3, 2025 08:41
@mrgrain mrgrain force-pushed the mrgrain/chore/new-toolkit-in-cli branch from 7693a57 to d748fae Compare April 4, 2025 18:19
@mrgrain mrgrain force-pushed the mrgrain/chore/new-toolkit-in-cli branch from d748fae to 8637c45 Compare April 4, 2025 18:24
@mrgrain mrgrain changed the title use new toolkit from old cli chore: enable using the new toolkit from cli Apr 4, 2025
@mrgrain mrgrain changed the base branch from main to mrgrain/refactor/move-the-rest April 4, 2025 18:25
@mrgrain mrgrain marked this pull request as ready for review April 4, 2025 18:25
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-the-rest branch from 1952cfe to 94e9675 Compare April 4, 2025 18:31
Base automatically changed from mrgrain/refactor/move-the-rest to main April 4, 2025 19:08
@mrgrain mrgrain force-pushed the mrgrain/chore/new-toolkit-in-cli branch from 8637c45 to 155804f Compare April 4, 2025 19:52
@mrgrain mrgrain force-pushed the mrgrain/chore/new-toolkit-in-cli branch from 155804f to 65e6493 Compare April 4, 2025 19:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (a9b456a) to head (952b711).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 94.44% 2 Missing ⚠️
packages/aws-cdk/lib/cxapp/cloud-executable.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   85.80%   85.42%   -0.38%     
==========================================
  Files         169      219      +50     
  Lines       20524    24103    +3579     
  Branches     2304     2583     +279     
==========================================
+ Hits        17610    20590    +2980     
- Misses       2867     3462     +595     
- Partials       47       51       +4     
Flag Coverage Δ
suite.unit 85.42% <92.59%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit d21e66e Apr 4, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/new-toolkit-in-cli branch April 4, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants