Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 4, 2025

Moves the context providers to the temporary helper package. Tests will be moved later to keep the diff size manageable. Code is still tested as the tests are still running from aws-cdk package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 4, 2025 15:45
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-context-providers branch from a677c2d to ed23992 Compare April 4, 2025 15:46
@mrgrain mrgrain changed the title Mrgrain/refactor/move context providers refactor(toolkit): move context providers Apr 4, 2025
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-context-providers branch from ed23992 to a9e3f74 Compare April 4, 2025 16:08
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Apr 4, 2025
Base automatically changed from mrgrain/refactor/move-deployment-apis to main April 4, 2025 17:02
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-context-providers branch from a9e3f74 to bbbe67a Compare April 4, 2025 17:07
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 4, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (d68d000) to head (bbbe67a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   86.23%   86.07%   -0.17%     
==========================================
  Files         173      173              
  Lines       23317    22003    -1314     
  Branches     2771     2518     -253     
==========================================
- Hits        20108    18939    -1169     
+ Misses       3147     3015     -132     
+ Partials       62       49      -13     
Flag Coverage Δ
suite.unit 86.07% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 5ce3aef Apr 4, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/move-context-providers branch April 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants