feat(refactor): ability to exclude selected resources from refactoring #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into otaviom/refactor-stack-filtering
otaviomacedo
commented
Apr 28, 2025
| * logical IDs, that is, the logical IDs of the resources | ||
| * as they would be after the refactor. | ||
| */ | ||
| skipFile?: string; |
Contributor
Author
There was a problem hiding this comment.
I'm looking for a better name. If anyone has any suggestions, let me know.
Contributor
There was a problem hiding this comment.
For toolkit-lib, this should be an array. We can make the read from file a CLI feature.
Contributor
There was a problem hiding this comment.
I'm looking for a better name. If anyone has any suggestions, let me know.
exclude?
Contributor
Author
There was a problem hiding this comment.
Yes, I'm going with exclude.
otaviomacedo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
# Conflicts: # packages/@aws-cdk/tmp-toolkit-helpers/src/api/refactoring/index.ts # packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts # packages/@aws-cdk/toolkit-lib/test/actions/refactor.test.ts # packages/aws-cdk/lib/cli/cli-config.ts # packages/aws-cdk/lib/cli/convert-to-user-input.ts # packages/aws-cdk/lib/cli/parse-command-line-arguments.ts # packages/aws-cdk/lib/cli/user-input.ts # packages/aws-cdk/test/api/refactoring/refactoring.test.ts
otaviomacedo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
otaviomacedo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
otaviomacedo
commented
Apr 29, 2025
packages/@aws-cdk/tmp-toolkit-helpers/src/api/refactoring/cloudformation.ts
Show resolved
Hide resolved
otaviomacedo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 79.15% 79.18% +0.03%
==========================================
Files 54 54
Lines 6889 6895 +6
Branches 772 773 +1
==========================================
+ Hits 5453 5460 +7
+ Misses 1418 1417 -1
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # packages/@aws-cdk/toolkit-lib/lib/api/refactoring/skip.ts # packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts # packages/aws-cdk/test/api/refactoring/refactoring.test.ts
otaviomacedo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
otaviomacedo
commented
Apr 30, 2025
otaviomacedo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to select resources to be skipped for refactoring. There are two ways to do this:
aws:cdk:skip-refactor = truemetadata to each resource to be skipped, in the cloud assembly manifest."<stack name>.<logical ID>"or a construct path.The main abstraction is the
SkipListinterface, used by the mapping detection algorithm to query for mappings that should be excluded.Closes #412, #379
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license