Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 30, 2025

Add integration tests for the toolkit library.

Introduces the toolkit library as a new "component under test".

Because we want to promote writing integ tests against the toolkit library the same way we would write normal production code, the setup is like this:

  • The toolkit lib is installed as a devDependency into the integ test package. This will allow writing tests as if the toolkit lib is "just" a dependency.
  • At runtime, a version of the toolkit library can be selected and it will be installed into the dependency closure by the runner before the tests are run, so that the imports will still function properly.

To signal this, we'll mark @aws-cdk/toolkit-lib as an optionalDependency as well.

(PR includes #444)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr marked this pull request as draft April 30, 2025 10:10
@github-actions github-actions bot added the p2 label Apr 30, 2025
@rix0rrr rix0rrr requested a review from a team April 30, 2025 10:10
@aws-cdk-automation aws-cdk-automation requested a review from a team April 30, 2025 10:11
@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from 47943df to b50e5bf Compare April 30, 2025 10:17
@rix0rrr rix0rrr marked this pull request as ready for review April 30, 2025 10:17
@rix0rrr rix0rrr marked this pull request as draft April 30, 2025 10:18
@rix0rrr rix0rrr changed the base branch from huijbers/integ-sources to main April 30, 2025 10:19
@github-actions
Copy link

Total lines changed 1113 is greater than 1000. Please consider breaking this PR down.

@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from b50e5bf to 72ee864 Compare April 30, 2025 10:55
@rix0rrr rix0rrr temporarily deployed to integ-approval April 30, 2025 10:55 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (7a950ef) to head (0fe8d7e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   79.17%   79.18%           
=======================================
  Files          54       54           
  Lines        6910     6912    +2     
  Branches      772      773    +1     
=======================================
+ Hits         5471     5473    +2     
  Misses       1421     1421           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from 325e9db to d3f7f9c Compare April 30, 2025 12:09
@rix0rrr rix0rrr temporarily deployed to integ-approval April 30, 2025 12:09 — with GitHub Actions Inactive
@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from d3f7f9c to f17137e Compare April 30, 2025 12:34
@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from f17137e to 968dab3 Compare April 30, 2025 12:37
@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from 968dab3 to 96ba475 Compare May 1, 2025 10:47
Signed-off-by: github-actions <github-actions@github.com>
@rix0rrr rix0rrr force-pushed the huijbers/toolkit-lib-integ branch from 1042535 to 0fe8d7e Compare May 6, 2025 13:10
@rix0rrr rix0rrr temporarily deployed to integ-approval May 6, 2025 13:10 — with GitHub Actions Inactive
@rix0rrr rix0rrr added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit d430b2e May 6, 2025
20 checks passed
@rix0rrr rix0rrr deleted the huijbers/toolkit-lib-integ branch May 6, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants