-
Notifications
You must be signed in to change notification settings - Fork 61
feat(integ-tests): add integ tests for the toolkit library #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
47943df to
b50e5bf
Compare
|
Total lines changed 1113 is greater than 1000. Please consider breaking this PR down. |
b50e5bf to
72ee864
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 79.17% 79.18%
=======================================
Files 54 54
Lines 6910 6912 +2
Branches 772 773 +1
=======================================
+ Hits 5471 5473 +2
Misses 1421 1421
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
325e9db to
d3f7f9c
Compare
d3f7f9c to
f17137e
Compare
f17137e to
968dab3
Compare
968dab3 to
96ba475
Compare
Signed-off-by: github-actions <github-actions@github.com>
1042535 to
0fe8d7e
Compare
Add integration tests for the toolkit library.
Introduces the toolkit library as a new "component under test".
Because we want to promote writing integ tests against the toolkit library the same way we would write normal production code, the setup is like this:
devDependencyinto the integ test package. This will allow writing tests as if the toolkit lib is "just" a dependency.To signal this, we'll mark
@aws-cdk/toolkit-libas anoptionalDependencyas well.(PR includes #444)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license