Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 1, 2025

Fixes the error messages not being include for generic LogMonitor errors.
Also updates the tests to be more reliable.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval May 1, 2025 09:24 — with GitHub Actions Inactive
@mrgrain mrgrain self-assigned this May 1, 2025
@github-actions github-actions bot added the p2 label May 1, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 1, 2025 09:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (cf68e32) to head (a72f7db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          54       54           
  Lines        6889     6889           
  Branches      773      772    -1     
=======================================
  Hits         5453     5453           
  Misses       1418     1418           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit 256fe96 May 1, 2025
25 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/log-monitor-error branch May 1, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants