Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 1, 2025

For historical reasons of working with Jest 27 or lower, we needed to mv the integ-tests out of an install directory where they would be left by an npm install. The reason was that Jest 27 or lower would always ignore all node_modules direcotries, and so could not be configured to run tests from an install location.

Since we are on Jest 29, we can now lift this limitation with the right configuration options. We can run the tests directly from the node_modules directory and don't have to fiddle around with moving files anymore.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

For historical reasons of working with Jest 27 or lower, we needed to
`mv` the `integ-tests` out of an install directory where they would be
left by an `npm install`. The reason was that Jest 27 or lower would
always ignore all `node_modules` direcotries, and so could not be
configured to run tests from an install location.

Since we are on Jest 29, we can now lift this limitation with the right
configuration options. We can run the tests directly from the `node_modules`
directory and don't have to fiddle around with moving files anymore.
@rix0rrr rix0rrr requested a review from a team May 1, 2025 12:37
@rix0rrr rix0rrr temporarily deployed to integ-approval May 1, 2025 12:37 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team May 1, 2025 12:38
@github-actions github-actions bot added the p2 label May 1, 2025
Signed-off-by: github-actions <github-actions@github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (e1a9030) to head (8a04935).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          54       54           
  Lines        6889     6889           
  Branches      773      773           
=======================================
  Hits         5453     5453           
  Misses       1418     1418           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr temporarily deployed to integ-approval May 1, 2025 17:28 — with GitHub Actions Inactive
Signed-off-by: github-actions <github-actions@github.com>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit f065877 May 2, 2025
21 of 23 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/run-tests-from-anywhere branch May 2, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants