generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 61
fix(integ-tests): tests need to mved before they can be run
#439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For historical reasons of working with Jest 27 or lower, we needed to `mv` the `integ-tests` out of an install directory where they would be left by an `npm install`. The reason was that Jest 27 or lower would always ignore all `node_modules` direcotries, and so could not be configured to run tests from an install location. Since we are on Jest 29, we can now lift this limitation with the right configuration options. We can run the tests directly from the `node_modules` directory and don't have to fiddle around with moving files anymore.
Signed-off-by: github-actions <github-actions@github.com>
mrgrain
approved these changes
May 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 54 54
Lines 6889 6889
Branches 773 773
=======================================
Hits 5453 5453
Misses 1418 1418
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons of working with Jest 27 or lower, we needed to
mvtheinteg-testsout of an install directory where they would be left by annpm install. The reason was that Jest 27 or lower would always ignore allnode_modulesdirecotries, and so could not be configured to run tests from an install location.Since we are on Jest 29, we can now lift this limitation with the right configuration options. We can run the tests directly from the
node_modulesdirectory and don't have to fiddle around with moving files anymore.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license