Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 7, 2025

Without these changes we only ever test against the publicly released version of @aws-cdk/toolkit-lib.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 7, 2025 12:14
Signed-off-by: github-actions <github-actions@github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (3823937) to head (c968df8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          54       54           
  Lines        6912     6912           
  Branches      773      773           
=======================================
  Hits         5473     5473           
  Misses       1421     1421           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr added the pr/exempt-integ-test Skips the integ test steps if set. label May 7, 2025
@rix0rrr rix0rrr closed this May 7, 2025
auto-merge was automatically disabled May 7, 2025 13:42

Pull request was closed

@rix0rrr rix0rrr reopened this May 7, 2025
@rix0rrr rix0rrr enabled auto-merge May 7, 2025 13:42
@rix0rrr rix0rrr added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit ed26efc May 7, 2025
26 of 28 checks passed
@rix0rrr rix0rrr deleted the huijbers/test-toolkit branch May 7, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants