fix(cdk-assets): indicate correct docker command that failed to execute #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may override the executable used (instead of `docker`) by setting the CDK_DOCKER environment variable, but the message of the error thrown when such a command does not exist was not similarly dynamic. Align the contents of the message with the executable invoked. Fixes aws#282. Signed-off-by: Ian Kerins <git@isk.haus>
mrgrain
approved these changes
May 19, 2025
mrgrain
reviewed
May 19, 2025
mrgrain
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 78.98% 78.98%
=======================================
Files 46 46
Lines 6994 6994
Branches 776 776
=======================================
Hits 5524 5524
Misses 1452 1452
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may override the executable used (instead of
docker) by setting the CDK_DOCKER environment variable, but the message of the error thrown when such an executable does not exist was not similarly dynamic. Align the contents of the message with the executable invoked.Fixes #282.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license