Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 19, 2025

This PR removes duplicate test helper functions in the toolkit-lib package to improve code maintainability and reduce redundancy.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval May 19, 2025 12:29 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2025 12:30
@github-actions github-actions bot added the p2 label May 19, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (ea4ba36) to head (ce1d0da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files          46       46           
  Lines        6994     6994           
  Branches      776      775    -1     
=======================================
  Hits         5524     5524           
  Misses       1452     1452           
  Partials       18       18           
Flag Coverage Δ
suite.unit 78.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit d5f6f8c May 19, 2025
26 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/toolkit-lib/test-helper-duplicates branch May 19, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants