fix(toolkit-lib): MFA token cannot be provided through IoHost #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/no-promptly-mfa
branch
from
5f6bc9f to
fd4d7ae
Compare
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/no-promptly-mfa
branch
from
af6d4ac to
a33350f
Compare
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 78.98% 79.59% +0.61%
==========================================
Files 46 46
Lines 6994 6998 +4
Branches 775 785 +10
==========================================
+ Hits 5524 5570 +46
+ Misses 1452 1407 -45
- Partials 18 21 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/no-promptly-mfa
branch
from
57f92d8 to
0fec7f9
Compare
mrgrain
commented
May 19, 2025
| const desc = responseDescription ?? prompt.default; | ||
| const answer = await promptly.prompt(`${chalk.cyan(msg.message)}${desc ? ` (${desc})` : ''}`, { | ||
| default: prompt.default, | ||
| trim: true, |
Contributor
Author
There was a problem hiding this comment.
I cannot imagine a situation we don't want to trim input. At least none of the current prompts want untrimmed.
rix0rrr
approved these changes
May 20, 2025
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/no-promptly-mfa
branch
from
0fec7f9 to
312e23e
Compare
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/no-promptly-mfa
branch
from
312e23e to
76c10d2
Compare
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/no-promptly-mfa
branch
from
76c10d2 to
fd78fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #396
Considering this a bug fix, since it is currently not possible to integrate an IoHost with this. While this does affect the CLI, the DX is virtually unchanged. I run the auth test suite to ensure everything is still working as expected.
Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license