-
Notifications
You must be signed in to change notification settings - Fork 60
refactor(cli): hotswap is now a deployment method #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6dd7f1b to
1c52125
Compare
2eb7851 to
a044261
Compare
| usePreviousParameters: options.usePreviousParameters, | ||
| rollback, | ||
| hotswap: options.hotswap, | ||
| hotswapPropertyOverrides: hotswapPropertyOverrides, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now handled in cli.ts
1c52125 to
a4d85e2
Compare
a044261 to
440a364
Compare
440a364 to
ddbdba2
Compare
ddbdba2 to
9a89317
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 78.92% 78.72% -0.21%
==========================================
Files 46 46
Lines 6980 6974 -6
Branches 777 772 -5
==========================================
- Hits 5509 5490 -19
- Misses 1452 1465 +13
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Follow-up from #517 to make the same changes to the CLI. This has no user impact.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license