Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 21, 2025

Follow-up from #517 to make the same changes to the CLI. This has no user impact.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 21, 2025 14:30
@github-actions github-actions bot added the p2 label May 21, 2025
@mrgrain mrgrain force-pushed the mrgrain/hotswap-deployment-method branch 2 times, most recently from 6dd7f1b to 1c52125 Compare May 21, 2025 16:13
@mrgrain mrgrain force-pushed the mrgrain/hotswap-cli-changes branch from 2eb7851 to a044261 Compare May 21, 2025 16:31
usePreviousParameters: options.usePreviousParameters,
rollback,
hotswap: options.hotswap,
hotswapPropertyOverrides: hotswapPropertyOverrides,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now handled in cli.ts

@mrgrain mrgrain force-pushed the mrgrain/hotswap-deployment-method branch from 1c52125 to a4d85e2 Compare May 21, 2025 16:47
@mrgrain mrgrain force-pushed the mrgrain/hotswap-cli-changes branch from a044261 to 440a364 Compare May 22, 2025 08:29
@mrgrain mrgrain force-pushed the mrgrain/hotswap-cli-changes branch from 440a364 to ddbdba2 Compare May 22, 2025 11:03
@mrgrain mrgrain temporarily deployed to integ-approval May 22, 2025 11:03 — with GitHub Actions Inactive
Base automatically changed from mrgrain/hotswap-deployment-method to main May 22, 2025 13:20
@mrgrain mrgrain force-pushed the mrgrain/hotswap-cli-changes branch from ddbdba2 to 9a89317 Compare May 22, 2025 14:38
@mrgrain mrgrain temporarily deployed to integ-approval May 22, 2025 14:39 — with GitHub Actions Inactive
@mrgrain mrgrain marked this pull request as ready for review May 22, 2025 14:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.25000% with 60 lines in your changes missing coverage. Please review.

Project coverage is 78.72%. Comparing base (0145866) to head (9a89317).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cli.ts 3.22% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   78.92%   78.72%   -0.21%     
==========================================
  Files          46       46              
  Lines        6980     6974       -6     
  Branches      777      772       -5     
==========================================
- Hits         5509     5490      -19     
- Misses       1452     1465      +13     
  Partials       19       19              
Flag Coverage Δ
suite.unit 78.72% <6.25%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 841bc03 May 23, 2025
25 checks passed
@mrgrain mrgrain deleted the mrgrain/hotswap-cli-changes branch May 23, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants