fix(toolkit-lib): create notices cache dir #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/toolkit-lib/create-notices-cache-dir
branch
from
e2487bf to
82fcd4e
Compare
iliapolo
reviewed
May 28, 2025
|
|
||
| private async save(cached: CachedNotices): Promise<void> { | ||
| try { | ||
| await fs.ensureFile(this.fileName); |
rix0rrr
approved these changes
May 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 79.09% 79.09%
=======================================
Files 47 47
Lines 7074 7074
Branches 790 791 +1
=======================================
Hits 5595 5595
Misses 1460 1460
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aws-cdk-automation
deleted the
mrgrain/fix/toolkit-lib/create-notices-cache-dir
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
Test cases for #545 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541
This PR ensures that the notices cache file exists before attempting to write to it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license