generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 60
fix(toolkit-lib): drift detection options are unnecessarily required #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aws-cdk-automation
merged 2 commits into
main
from
mrgrain/fix/toolkit-lib/drift-changes
May 29, 2025
Merged
fix(toolkit-lib): drift detection options are unnecessarily required #552
aws-cdk-automation
merged 2 commits into
main
from
mrgrain/fix/toolkit-lib/drift-changes
May 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
requested changes
May 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 79.09% 79.09%
=======================================
Files 47 47
Lines 7074 7074
Branches 791 791
=======================================
Hits 5595 5595
Misses 1460 1460
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the drift detection implementation in the CDK toolkit-lib by making the 'stacks' parameter optional in the DriftOptions interface and providing default options in the toolkit.drift() method. These changes enhance the API's usability and consistency.
Changes:
These changes make the drift detection API more flexible and consistent with other toolkit methods that typically provide default options.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license