Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 29, 2025

Description

This PR improves the drift detection implementation in the CDK toolkit-lib by making the 'stacks' parameter optional in the DriftOptions interface and providing default options in the toolkit.drift() method. These changes enhance the API's usability and consistency.

Changes:

  1. Made 'stacks' parameter optional in DriftOptions interface
  2. Added default empty options object to toolkit.drift() method
  3. Added a test case to verify that drift action can be invoked without options

These changes make the drift detection API more flexible and consistent with other toolkit methods that typically provide default options.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval May 29, 2025 09:37 — with GitHub Actions Inactive
@github-actions github-actions bot added the p2 label May 29, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 29, 2025 09:38
@mrgrain mrgrain changed the title fix(toolkit-lib): update drift detection implementation fix(toolkit-lib): make drift detection options optional May 29, 2025
@mrgrain mrgrain changed the title fix(toolkit-lib): make drift detection options optional fix(toolkit-lib): drift detection options are unnecessarily required May 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.09%. Comparing base (f227c9b) to head (d550323).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          47       47           
  Lines        7074     7074           
  Branches      791      791           
=======================================
  Hits         5595     5595           
  Misses       1460     1460           
  Partials       19       19           
Flag Coverage Δ
suite.unit 79.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain temporarily deployed to integ-approval May 29, 2025 13:14 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit 60506e5 May 29, 2025
32 of 34 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/toolkit-lib/drift-changes branch May 29, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants