Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 16, 2025

Updates the context overflow support detection logic to consider developer builds (with version 0.0.0) as supported. This has no customer facing impact but prevents an incorrect debug message from being emitted when using a dev build of the framework, e.g. when running integ tests in the aws/aws-cdk repo.

Also extracts the context overflow detection logic into a separate function to improve testability and maintainability. Added unit tests to ensure the function works correctly with different CDK versions.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval July 16, 2025 12:27 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team July 16, 2025 12:27
@github-actions github-actions bot added the p2 label Jul 16, 2025
@mrgrain mrgrain changed the title refactor(toolkit-lib): extract context overflow detection logic chore(toolkit-lib): consider developer builds as supporting context overflow Jul 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (51a1406) to head (560558d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   79.41%   80.06%   +0.65%     
==========================================
  Files          50       50              
  Lines        7295     7295              
  Branches      825      831       +6     
==========================================
+ Hits         5793     5841      +48     
+ Misses       1483     1432      -51     
- Partials       19       22       +3     
Flag Coverage Δ
suite.unit 80.06% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit 9237774 Jul 16, 2025
42 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/toolkit-lib/context-overflow-detection branch July 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants