Skip to content

Conversation

vivian12300
Copy link
Contributor

@vivian12300 vivian12300 commented Aug 4, 2025

Notify users about the number of unconfigured feature flags in their application and the cdk flags command when they run cdk synth.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 4, 2025 14:15
@github-actions github-actions bot added the p2 label Aug 4, 2025
@vivian12300 vivian12300 changed the title feat: add message about unconfigured flags when user runs cdk synth feat: add message about unconfigured feature flags when user runs cdk synth Aug 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.32%. Comparing base (c6e6c46) to head (ea90145).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
+ Coverage   81.21%   81.32%   +0.11%     
==========================================
  Files          61       62       +1     
  Lines        8267     8284      +17     
  Branches      949      955       +6     
==========================================
+ Hits         6714     6737      +23     
+ Misses       1528     1522       -6     
  Partials       25       25              
Flag Coverage Δ
suite.unit 81.32% <84.21%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou added this pull request to the merge queue Aug 4, 2025
Merged via the queue into aws:main with commit a94b241 Aug 4, 2025
27 checks passed
@vivian12300 vivian12300 deleted the flag-message branch August 4, 2025 17:46
iankhou pushed a commit that referenced this pull request Aug 21, 2025
…k synth` (#765)

#### Notify users about the number of unconfigured feature flags in
their application and the `cdk flags` command when they run `cdk synth`.
---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants