Skip to content

Conversation

@ren-yamanashi
Copy link
Contributor

@ren-yamanashi ren-yamanashi commented Aug 18, 2025

Fixes #660

Description Changes

When running cdk init, if the specified command type can only be executed in a single language, allow the command to be executed without selecting a language.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ren-yamanashi ren-yamanashi marked this pull request as ready for review August 18, 2025 12:51
@iankhou iankhou self-assigned this Aug 21, 2025
Copy link
Contributor

@iankhou iankhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The original warning seemed to imply that if there was only one language, the command would work without specifying it. Good catch!

Screenshot 2025-08-21 at 12 25 15

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.91%. Comparing base (455c017) to head (ae14c54).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   81.46%   80.91%   -0.56%     
==========================================
  Files          63       63              
  Lines        8611     8618       +7     
  Branches     1039     1035       -4     
==========================================
- Hits         7015     6973      -42     
- Misses       1565     1616      +51     
+ Partials       31       29       -2     
Flag Coverage Δ
suite.unit 80.91% <100.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou added this pull request to the merge queue Aug 21, 2025
Merged via the queue into aws:main with commit 80d4d15 Aug 21, 2025
27 checks passed
iankhou pushed a commit that referenced this pull request Aug 21, 2025
Fixes #660 

### Description Changes

When running `cdk init`, if the specified command type can only be
executed in a single language, allow the command to be executed without
selecting a language.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
@ren-yamanashi ren-yamanashi deleted the fix/cdk-init-lib-default branch November 10, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cdk: cdk init lib doest not properly default to typescript

3 participants