-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: 0107 Construct Library Module Lifecycle Updates #130
Conversation
…per Preview exit criteria
pulling in changes from online review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this show as a brand new file? I expected to find a diff against the current version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally approved.
The reason it’s not showing a proper diff is because you have merge conflicts. You need to update your fork with the latest changes from this repo |
> **Automation Opportunity:** When a new module is automatically added to the AWS Construct Library, also | ||
> auto-generate the module's tracking issue so that it can be assigned an owner as part of the Open Source Developer | ||
> Support (OSDS) team's issue triage process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a tracking issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now: https://github.com/aws/cdk-ops/issues/538
title: "RFC: #107 aws-construct-library-module-lifecycle"
labels: management/rfc
Updated the RFC to reflect the current state rather than being a working backward document.
Rendered version
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license