Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: 0107 Construct Library Module Lifecycle Updates #130

Merged
merged 14 commits into from
Feb 26, 2020
Merged

Conversation

ccfife
Copy link
Contributor

@ccfife ccfife commented Feb 25, 2020


title: "RFC: #107 aws-construct-library-module-lifecycle"
labels: management/rfc

Updated the RFC to reflect the current state rather than being a working backward document.

Rendered version


By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this show as a brand new file? I expected to find a diff against the current version...

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved.

@iliapolo
Copy link
Contributor

The reason it’s not showing a proper diff is because you have merge conflicts. You need to update your fork with the latest changes from this repo

@ccfife ccfife requested a review from eladb February 25, 2020 21:02
Comment on lines -52 to -54
> **Automation Opportunity:** When a new module is automatically added to the AWS Construct Library, also
> auto-generate the module's tracking issue so that it can be assigned an owner as part of the Open Source Developer
> Support (OSDS) team's issue triage process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a tracking issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladb eladb changed the title RFC0107 Construct Library Module Lifecycle Updates RFC: 0107 Construct Library Module Lifecycle Updates Feb 26, 2020
@eladb eladb merged commit d01d73e into aws:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants