-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify RFC format #222
Conversation
A proposal to reduce the complexity of RFCs by simplifying the template to a PR/FAQ format.
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
> | ||
> - [Graphviz](http://graphviz.it/#/gallery/structs.gv) | ||
> - [PlantText](https://www.planttext.com) | ||
> If this is a major feature (~6 months of work), write the PRESS RELEASE which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is covered in Working Backwards above. We should merge these paragraphs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the working backwards section. Not sure I follow...
How is this a simplification? It's hard to tell from the diff how this makes an RFC easier/faster to write. |
@ericzbeard - how do you propose this be made visible? The nature of applying unified diff on markdown docs does not render for nice diff'ing. I've updated the commit description with a link to the rendered version. You should be able to side by side compare the old rendered version with the new one to see if this is simplified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, I think it makes the RFC process more of a tool to help the writer frame their thoughts than a chore.
One general comment, the addition of the Press release
creates redundancy with others section, for example: CHANGELOG and "What are we launching today" + "Is this a breaking change". I would suggest dropping the README section and the CHANGELOG section in favor of the press release.
|
||
# Design Summary | ||
### README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the README
section in addition to the content of the PRESS RELEASE
and Working Backwards
, I feel like there will be a lot of duplicate between the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See line 12, the requirement is to include "one or more artifacts", not all of them.
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Added 'do-not-merge' to give others a chance to take a look.
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
A proposal to reduce the complexity of RFCs by simplifying the template to a PR/FAQ format.
Rendered version