multiple vs single unstable module #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Jan 11, 2021
| The advantages of vending as separate modules: | ||
|
|
||
| 1. The same experience as any other 3rd party library. | ||
| 2. Easier for 3rd parties to contribute modules, which we can first incubate |
There was a problem hiding this comment.
Not sure i understand this point
|
|
||
| We know from our current dependency tree, that unstable modules depending on | ||
| other unstable modules is a valid use case. From the 35 unstable modules we | ||
| currently have, ~3 of them depends on other unstable modules. |
There was a problem hiding this comment.
Which ones? It's important to understand the nature of the dependency
| `peerDependencies`. | ||
|
|
||
| The main concern raised in the PR was that doing so will result in "the same | ||
| dependency hell monocdk was meant to solve". As commented on the PR, this is not |
There was a problem hiding this comment.
This also brings up again the fact that those will be exactly like any 3rd party module in the ecosystem so if we have an issue it applies to the entire ecosystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged, it is only meant to allow us to separately discuss one aspect of the V2 Experiments RFC.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license