RFC 308: CLI notices #389
Merged
RFC 308: CLI notices #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
previously requested changes
Nov 29, 2021
|
This should be a report as well, advices could be forgotten after they keep showing on the screen |
Chriscbr
reviewed
Nov 30, 2021
eladb
reviewed
Dec 10, 2021
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
rix0rrr
reviewed
Dec 14, 2021
rix0rrr
reviewed
Dec 14, 2021
eladb
reviewed
Dec 14, 2021
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
corymhall
reviewed
Dec 14, 2021
2 tasks
eladb
reviewed
Jan 11, 2022
eladb
approved these changes
Jan 11, 2022
|
Looking forward to seeing this in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request for comments about CLI notices.
See #308 for additional details.
APIs are signed off by @eladb.
Readable version
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license