Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 473: EventBridge Pipes L2 Construct #488

Merged
merged 4 commits into from
Oct 25, 2023
Merged

RFC 473: EventBridge Pipes L2 Construct #488

merged 4 commits into from
Oct 25, 2023

Conversation

RaphaelManke
Copy link
Contributor

@RaphaelManke RaphaelManke commented Mar 15, 2023 •
edited by mrgrain
Loading

This is a request for comments about EventBridge Pipes L2 Construct See #473 for
additional details.

Closes: #473

APIs are signed off by @mrgrain

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

@RaphaelManke RaphaelManke mentioned this pull request Mar 15, 2023
Closed
11 tasks
@RaphaelManke RaphaelManke changed the title RFC-472-initial-draft RFC-472 - EventBridge Pipes L2 Construct Mar 15, 2023
@RaphaelManke RaphaelManke changed the title RFC-472 - EventBridge Pipes L2 Construct RFC-473 - EventBridge Pipes L2 Construct Mar 15, 2023
@RaphaelManke RaphaelManke changed the title RFC-473 - EventBridge Pipes L2 Construct RFC 473: EventBridge Pipes L2 Construct Mar 15, 2023
@RaphaelManke RaphaelManke force-pushed the rfc-472-eventbridge-pipes branch 5 times, most recently from f517ce8 to ce9c3f1 Compare March 21, 2023 07:15
@evgenyka evgenyka added the l2-request request for new L2 construct label Aug 10, 2023
@RaphaelManke RaphaelManke force-pushed the rfc-472-eventbridge-pipes branch from 74863b6 to 2601770 Compare September 6, 2023 16:49
@RaphaelManke RaphaelManke force-pushed the rfc-472-eventbridge-pipes branch from 2601770 to bdc6d7e Compare September 6, 2023 16:49
@RaphaelManke
Copy link
Contributor Author

RaphaelManke commented Oct 11, 2023 •
edited
Loading

Hi @mrgrain, @spac3lord did one of you find the time already to review the PR? Is it covering enough or are there things missing.
As this RFC is still part of the old RFC process, the pending RFC PR blocks the possibility to add an alpha module to the cdk repo.
I'd personally would love to see this merged prior to Re:Invent, before new features need to be considered 😅

@mrgrain
Copy link
Contributor

mrgrain commented Oct 17, 2023

Thanks @RaphaelManke Apologies for the delay. I'm happy with this now and are putting it into final comments period.

@mrgrain mrgrain self-assigned this Oct 20, 2023
mrgrain
mrgrain previously approved these changes Oct 25, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

Thank you for contributing! Your pull request is now being automatically merged.

@mrgrain
Copy link
Contributor

mrgrain commented Oct 25, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/pr-lint.yml without workflows permission

@mergify mergify bot dismissed mrgrain’s stale review October 25, 2023 15:49

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit d539f23 into aws:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

@mrgrain mrgrain

Labels
l2-request request for new L2 construct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventBridge Pipes L2 Construct
3 participants
@RaphaelManke @mrgrain @evgenyka