fix(globalaccelerator): change onCreate to onUpdate handler for globa…

…laccelerator custom resource handler to fix cloudFormation update failure
aws · Mar 26, 2024 · 06f0c0c · 06f0c0c
1 parent f60e6e9
commit 06f0c0c
Show file tree

Hide file tree

Showing 14 changed files with 193 additions and 250 deletions.
diff --git a/...dpoints.js.snapshot/GlobalAcceleratorEndpointsDefaultTestDeployAssert3F2DB71B.assets.json b/...dpoints.js.snapshot/GlobalAcceleratorEndpointsDefaultTestDeployAssert3F2DB71B.assets.json
diff --git a/.../asset.18d379b052acd60e0d086d5b19d9bef956ebc0bd018c5570960125aab0c7f837/__entrypoint__.js b/.../asset.18d379b052acd60e0d086d5b19d9bef956ebc0bd018c5570960125aab0c7f837/__entrypoint__.js
diff --git a/....snapshot/asset.18d379b052acd60e0d086d5b19d9bef956ebc0bd018c5570960125aab0c7f837/index.js b/....snapshot/asset.18d379b052acd60e0d086d5b19d9bef956ebc0bd018c5570960125aab0c7f837/index.js
diff --git a/....snapshot/asset.482f9f5ffd706706c8ef3652699d6c945568786593d3571e4331ecb1f966c932/index.js b/....snapshot/asset.482f9f5ffd706706c8ef3652699d6c945568786593d3571e4331ecb1f966c932/index.js
diff --git a/....snapshot/asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db/index.js b/....snapshot/asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db/index.js
diff --git a/.../asset.e978ad4ad0dca7e1c6be5f49cbbd1c5a150ee050c24052fedfe5a42f835d55da/__entrypoint__.js b/.../asset.e978ad4ad0dca7e1c6be5f49cbbd1c5a150ee050c24052fedfe5a42f835d55da/__entrypoint__.js
diff --git a/....snapshot/asset.e978ad4ad0dca7e1c6be5f49cbbd1c5a150ee050c24052fedfe5a42f835d55da/index.js b/....snapshot/asset.e978ad4ad0dca7e1c6be5f49cbbd1c5a150ee050c24052fedfe5a42f835d55da/index.js
diff --git a/...teg/test/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/cdk.out b/...teg/test/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/cdk.out
diff --git a/...t/integ.globalaccelerator-endpoints.js.snapshot/global-accelerator-endpoints2.assets.json b/...t/integ.globalaccelerator-endpoints.js.snapshot/global-accelerator-endpoints2.assets.json
diff --git a/...integ.globalaccelerator-endpoints.js.snapshot/global-accelerator-endpoints2.template.json b/...integ.globalaccelerator-endpoints.js.snapshot/global-accelerator-endpoints2.template.json
@@ -489,7 +489,7 @@
      "S3Bucket": {
       "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
      },
-     "S3Key": "18d379b052acd60e0d086d5b19d9bef956ebc0bd018c5570960125aab0c7f837.zip"
+     "S3Key": "e978ad4ad0dca7e1c6be5f49cbbd1c5a150ee050c24052fedfe5a42f835d55da.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,
@@ -579,6 +579,18 @@
       ]
      ]
     },
+    "Update": {
+     "Fn::Join": [
+      "",
+      [
+       "{\"service\":\"EC2\",\"action\":\"describeSecurityGroups\",\"parameters\":{\"Filters\":[{\"Name\":\"group-name\",\"Values\":[\"GlobalAccelerator\"]},{\"Name\":\"vpc-id\",\"Values\":[\"",
+       {
+        "Ref": "Vpc8378EB38"
+       },
+       "\"]}]},\"physicalResourceId\":{\"responsePath\":\"SecurityGroups.0.GroupId\"}}"
+      ]
+     ]
+    },
     "InstallLatestAwsSdk": false
    },
    "DependsOn": [
@@ -699,7 +711,7 @@
      "S3Bucket": {
       "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
      },
-     "S3Key": "e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db.zip"
+     "S3Key": "482f9f5ffd706706c8ef3652699d6c945568786593d3571e4331ecb1f966c932.zip"
     },
     "Handler": "index.handler",
     "Role": {

diff --git a/.../test/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/integ.json b/.../test/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/integ.json
diff --git a/...st/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/manifest.json b/...st/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/manifest.json
diff --git a/...g/test/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/tree.json b/...g/test/aws-globalaccelerator/test/integ.globalaccelerator-endpoints.js.snapshot/tree.json
diff --git a/packages/aws-cdk-lib/aws-globalaccelerator/lib/_accelerator-security-group.ts b/packages/aws-cdk-lib/aws-globalaccelerator/lib/_accelerator-security-group.ts
@@ -29,7 +29,7 @@ export class AcceleratorSecurityGroupPeer implements ec2.IPeer {
 
     // The AWS Custom Resource that make a call to EC2 to get the security group ID, for the given VPC
     const lookupAcceleratorSGCustomResource = new AwsCustomResource(scope, id + 'CustomResource', {
-      onCreate: {
+      onUpdate: {
         service: 'EC2',
         action: 'describeSecurityGroups',
         parameters: {