Skip to content

Commit

Permalink
fix(eks): integ tests errors (#24276)
Browse files Browse the repository at this point in the history
This PR fixes the integ tests errors in aws-eks and addresses the following issues:

`integ.alb-controller.ts` has `runAsNonRoot` error and should define a non-root user in securityContext of the pod definition to ensure successful k8s deployment.

`integ.eks-service-account-sdk-call.ts` should define a non-root user as well and increase the timeout of `BucketPinger` from the default 1 min to 3 min as the deployment could take up to 2 minutes or more. The base docker image from docker hub for this test has been replaced with the same image in ECR public to avoid potential throttling.

I have manually run the two integ tests in my account and both successfully deploy with no error now.

Closes #24266

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
pahud authored Feb 22, 2023
1 parent 549f912 commit 07f2d7b
Show file tree
Hide file tree
Showing 88 changed files with 1,008 additions and 1,526 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Construct } from 'constructs';

export interface BucketPingerProps {
readonly bucketName: string;
readonly timeout?: Duration;
}
export class BucketPinger extends Construct {

Expand All @@ -18,7 +19,7 @@ export class BucketPinger extends Construct {
code: lambda.Code.fromAsset(`${__dirname}/function`),
handler: 'index.handler',
runtime: lambda.Runtime.PYTHON_3_9,
timeout: Duration.minutes(1),
timeout: props.timeout ?? Duration.minutes(1),
environment: {
BUCKET_NAME: props.bucketName,
},
Expand Down
Binary file not shown.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 07f2d7b

Please sign in to comment.