Revert "fix(aws-cdk): include nested stacks when building changesets (#…

…19494)" This reverts commit 97cc8e2.
aws · Mar 29, 2022 · 090b158 · 090b158
1 parent 9b4a22e
commit 090b158
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 21 deletions.
diff --git a/packages/aws-cdk/lib/api/deploy-stack.ts b/packages/aws-cdk/lib/api/deploy-stack.ts
@@ -299,7 +299,6 @@ async function prepareAndExecuteChangeSet(
     StackName: deployName,
     ChangeSetName: changeSetName,
     ChangeSetType: update ? 'UPDATE' : 'CREATE',
-    IncludeNestedStacks: true,
     Description: `CDK Changeset for execution ${executionId}`,
     TemplateBody: bodyParameter.TemplateBody,
     TemplateURL: bodyParameter.TemplateURL,

diff --git a/packages/aws-cdk/test/api/deploy-stack.test.ts b/packages/aws-cdk/test/api/deploy-stack.test.ts
@@ -164,18 +164,6 @@ test('correctly passes CFN parameters, ignoring ones with empty values', async (
   }));
 });
 
-test('correctly passes IncludeNestedStacks', async () => {
-  // WHEN
-  await deployStack({
-    ...standardDeployStackArguments(),
-  });
-
-  // THEN
-  expect(cfnMocks.createChangeSet).toHaveBeenCalledWith(expect.objectContaining({
-    IncludeNestedStacks: true,
-  }));
-});
-
 test('reuse previous parameters if requested', async () => {
   // GIVEN
   givenStackExists({

diff --git a/packages/aws-cdk/test/integ/cli/cli.integtest.ts b/packages/aws-cdk/test/integ/cli/cli.integtest.ts
@@ -638,13 +638,10 @@ integTest('fast deploy', withDefaultFixture(async (fixture) => {
   const changeSet2 = await getLatestChangeSet();
   expect(changeSet2.ChangeSetId).toEqual(changeSet1.ChangeSetId);
 
-  // Deploy the stack again with --force. This creates a changeset which will be
-  // empty (since CFN now tracks changes into nested stacks as well), so we delete
-  // it again because it couldn't be executed anyway.
-  const output = await fixture.cdkDeploy('with-nested-stack', { options: ['--force'] });
+  // Deploy the stack again with --force, now we should create a changeset
+  await fixture.cdkDeploy('with-nested-stack', { options: ['--force'] });
   const changeSet3 = await getLatestChangeSet();
-  expect(output).toContain('No changes are to be performed on');
-  expect(changeSet3.ChangeSetId).toEqual(changeSet2.ChangeSetId);
+  expect(changeSet3.ChangeSetId).not.toEqual(changeSet2.ChangeSetId);
 
   // Deploy the stack again with tags, expected to create a new changeset
   // even though the resources didn't change.

diff --git a/packages/aws-cdk/test/integ/helpers/cdk.ts b/packages/aws-cdk/test/integ/helpers/cdk.ts
@@ -720,9 +720,11 @@ export async function installNpmPackages(fixture: TestFixture, packages: Record<
 const installNpm7 = memoize0(async (): Promise<string> => {
   const installDir = path.join(os.tmpdir(), 'cdk-integ-npm7');
   await shell(['rm', '-rf', installDir]);
-  await shell(['mkdir', '-p', `${installDir}/node_modules`]);
+  await shell(['mkdir', '-p', installDir]);
 
-  await shell(['npm', 'install', 'npm@7'], { cwd: installDir });
+  await shell(['npm', 'install',
+    '--prefix', installDir,
+    'npm@7']);
 
   return path.join(installDir, 'node_modules', '.bin', 'npm');
 });