Skip to content

Commit

Permalink
Fix @aws-cdk/app-delivery so it also passes IRole through
Browse files Browse the repository at this point in the history
  • Loading branch information
RomainMuller committed Dec 14, 2018
1 parent 90b5295 commit 0c6e2f3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export interface PipelineDeployStackActionProps {
*
* @default A fresh role with admin or no permissions (depending on the value of `adminPermissions`).
*/
role?: iam.Role;
role?: iam.IRole;

/**
* Acknowledge certain changes made as part of deployment
Expand Down Expand Up @@ -97,7 +97,7 @@ export class PipelineDeployStackAction extends cdk.Construct {
/**
* The role used by CloudFormation for the deploy action
*/
public readonly role: iam.Role;
public readonly role: iam.IRole;

private readonly stack: cdk.Stack;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export = nodeunit.testCase({
adminPermissions: false,
role
});
test.deepEqual(role.id, deployAction.role.id);
test.deepEqual(role.id, (deployAction.role as iam.Role).id);
test.done();
},
'users can specify IAM permissions for the deploy action'(test: nodeunit.Test) {
Expand Down

0 comments on commit 0c6e2f3

Please sign in to comment.