Improve initialization, add test for absent

aws · Apr 6, 2024 · 0ea9435 · 0ea9435
1 parent fd3537b
commit 0ea9435
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/packages/aws-cdk-lib/aws-ecs/README.md b/packages/aws-cdk-lib/aws-ecs/README.md
@@ -603,7 +603,7 @@ taskDefinition.addContainer('container', {
 
 ## Docker labels
 
-You can add labels to the container with the `dockerLabels` prop or `addDockerLabel`:
+You can add labels to the container with the `dockerLabels` property or with the `addDockerLabel` method:
 
 ```ts
 declare const taskDefinition: ecs.TaskDefinition;

diff --git a/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts b/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts
@@ -543,11 +543,7 @@ export class ContainerDefinition extends Construct {
       }
     }
 
-    if (props.dockerLabels) {
-      this.dockerLabels = { ...props.dockerLabels };
-    } else {
-      this.dockerLabels = {};
-    }
+    this.dockerLabels = { ...props.dockerLabels };
 
     if (props.environment) {
       this.environment = { ...props.environment };

diff --git a/packages/aws-cdk-lib/aws-ecs/test/container-definition.test.ts b/packages/aws-cdk-lib/aws-ecs/test/container-definition.test.ts
@@ -1209,6 +1209,27 @@ describe('container definition', () => {
     });
   });
 
+  test('docker labels should be absent if not supplied', () => {
+    // GIVEN
+    const stack = new cdk.Stack();
+    const taskDefinition = new ecs.Ec2TaskDefinition(stack, 'TaskDef');
+
+    // WHEN
+    taskDefinition.addContainer('cont', {
+      image: ecs.ContainerImage.fromRegistry('test'),
+      memoryLimitMiB: 1024,
+    });
+
+    // THEN
+    Template.fromStack(stack).hasResourceProperties('AWS::ECS::TaskDefinition', {
+      ContainerDefinitions: [
+        Match.objectLike({
+          DockerLabels: Match.absent(),
+        }),
+      ],
+    });
+  });
+
   test('can add environment variables to the container definition', () => {
     // GIVEN
     const stack = new cdk.Stack();