Skip to content

Commit

Permalink
fix(cli): pin geonamescache dependency to 1.3 (#21152)
Browse files Browse the repository at this point in the history
Our integ tests are failing because geonamescache recently [released](https://github.com/aws/aws-cdk/pull/21152/files) v1.4 and we are hardcoding v1.3 in our cli tests. This is currently blocking CDK v1.164.0's release, which has a p0 fix, so I'm simply pinning the dependency and we can worry about any potentially better solutions later.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
kaizencc authored Jul 15, 2022
1 parent 683298e commit 10f4304
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
geonamescache
geonamescache==1.3.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
geonamescache
geonamescache==1.3.0

0 comments on commit 10f4304

Please sign in to comment.