Skip to content

Commit

Permalink
fix(cli): remove warning about assets not included in diff (#4454)
Browse files Browse the repository at this point in the history
Since source hash is now used to identify assets, if an asset changes,
the diff will show it (yey!).

Resolves #395
  • Loading branch information
Elad Ben-Israel authored and mergify[bot] committed Oct 10, 2019
1 parent 1958f26 commit 123c594
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions packages/aws-cdk/lib/diff.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ export function printStackDiff(
context: number,
stream?: FormatStream): number {

if (newTemplate.assets.length > 0) {
const issue = 'https://github.com/aws/aws-cdk/issues/395';
warning(`The ${newTemplate.name} stack uses assets, which are currently not accounted for in the diff output! See ${issue}`);
}

const diff = cfnDiff.diffTemplate(oldTemplate, newTemplate.template);

// filter out 'AWS::CDK::Metadata' resources from the template
Expand Down

0 comments on commit 123c594

Please sign in to comment.