fix(ecs-patterns): remove duplicated schedule property for scheduled …

…task pattern (#6101) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
aws · Feb 5, 2020 · 15b6aa7 · 15b6aa7
1 parent 4aabeb8
commit 15b6aa7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/allowed-breaking-changes.txt b/allowed-breaking-changes.txt
@@ -12,6 +12,14 @@ removed:@aws-cdk/aws-apigateway.HttpIntegration.props
 removed:@aws-cdk/aws-apigateway.Integration.props
 removed:@aws-cdk/aws-apigateway.LambdaIntegration.props
 removed:@aws-cdk/aws-apigateway.MockIntegration.props
+removed:@aws-cdk/aws-ecs-patterns.ScheduledEc2TaskDefinitionOptions.schedule
+removed:@aws-cdk/aws-ecs-patterns.ScheduledEc2TaskDefinitionOptions.cluster
+removed:@aws-cdk/aws-ecs-patterns.ScheduledEc2TaskDefinitionOptions.desiredTaskCount
+removed:@aws-cdk/aws-ecs-patterns.ScheduledEc2TaskDefinitionOptions.vpc
+removed:@aws-cdk/aws-ecs-patterns.ScheduledFargateTaskDefinitionOptions.schedule
+removed:@aws-cdk/aws-ecs-patterns.ScheduledFargateTaskDefinitionOptions.cluster
+removed:@aws-cdk/aws-ecs-patterns.ScheduledFargateTaskDefinitionOptions.desiredTaskCount
+removed:@aws-cdk/aws-ecs-patterns.ScheduledFargateTaskDefinitionOptions.vpc
 incompatible-argument:@aws-cdk/aws-lambda.Function.<initializer>
 incompatible-argument:@aws-cdk/aws-lambda.SingletonFunction.<initializer>
 incompatible-argument:@aws-cdk/aws-lambda.Function.addEnvironment

diff --git a/packages/@aws-cdk/aws-ecs-patterns/lib/ecs/scheduled-ecs-task.ts b/packages/@aws-cdk/aws-ecs-patterns/lib/ecs/scheduled-ecs-task.ts
@@ -64,7 +64,7 @@ export interface ScheduledEc2TaskImageOptions extends ScheduledTaskImageProps {
 /**
  * The properties for the ScheduledEc2Task using a task definition.
  */
-export interface ScheduledEc2TaskDefinitionOptions extends ScheduledTaskBaseProps {
+export interface ScheduledEc2TaskDefinitionOptions {
   /**
    * The task definition to use for tasks in the service. One of image or taskDefinition must be specified.
    *

diff --git a/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/scheduled-fargate-task.ts b/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/scheduled-fargate-task.ts
@@ -62,7 +62,7 @@ export interface ScheduledFargateTaskImageOptions extends ScheduledTaskImageProp
 /**
  * The properties for the ScheduledFargateTask using a task definition.
  */
-export interface ScheduledFargateTaskDefinitionOptions extends ScheduledTaskBaseProps {
+export interface ScheduledFargateTaskDefinitionOptions {
   /**
    * The task definition to use for tasks in the service. Image or taskDefinition must be specified, but not both.
    *