fix(aws-codedeploy): implicitly create application in ServerDeploymen…

…tGroup fixes #13337
aws · Mar 14, 2021 · 198c2e5 · 198c2e5
1 parent 165a3d8
commit 198c2e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-codedeploy/lib/server/deployment-group.ts b/packages/@aws-cdk/aws-codedeploy/lib/server/deployment-group.ts
@@ -269,7 +269,7 @@ export class ServerDeploymentGroup extends ServerDeploymentGroupBase {
       physicalName: props.deploymentGroupName,
     });
 
-    this.application = props.application || new ServerApplication(this, 'Application');
+    this.application = props.application || new ServerApplication(this, this.physicalName);
 
     this.role = props.role || new iam.Role(this, 'Role', {
       assumedBy: new iam.ServicePrincipal('codedeploy.amazonaws.com'),

diff --git a/packages/@aws-cdk/aws-codedeploy/test/server/test.deployment-group.ts b/packages/@aws-cdk/aws-codedeploy/test/server/test.deployment-group.ts
@@ -28,6 +28,18 @@ export = {
       test.done();
     },
 
+    'with creating an application implicitly'(test: Test) {
+      const stack = new cdk.Stack();
+
+      const deploymentGroup = new codedeploy.ServerDeploymentGroup(stack, 'MyDG', {
+        deploymentGroupName: 'MyDG',
+      });
+
+      test.notEqual(deploymentGroup, undefined);
+
+      test.done();
+    },
+
     'can be imported'(test: Test) {
       const stack = new cdk.Stack();
 
@@ -38,7 +50,7 @@ export = {
       });
 
       test.notEqual(deploymentGroup, undefined);
-
+      
       test.done();
     },