Skip to content

Commit

Permalink
chore(contributing): mention manual PR merge option (#32126)
Browse files Browse the repository at this point in the history
Folks are probably already doing this, but just clarify that when a PR is failing status checks you can ping a maintainer for a manual merge if you think its justified. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
iliapolo authored Nov 14, 2024
1 parent fb97684 commit 339fed1
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,11 @@ console.log('This cannot be covered')
* Once approved and tested, one of our bots will squash-merge to main and will use your PR title/description as the
commit message.

> [!NOTE]
> If your PR is failing one of the required checks (e.g Codecov), it will not be auto-merged. If you believe the PR should be merged
> inspite of this, let a maintainer know. The maintainer may agree and merge the PR manually, or ask you to address the failing checks.

## Breaking Changes

**_NOTE_**: _Starting with version 2.0.0 of the AWS CDK, **all modules and members vended as part of the main CDK library**_
Expand Down

0 comments on commit 339fed1

Please sign in to comment.