Skip to content

Commit

Permalink
chore: Method signatures on sqs.ITopic (#1828)
Browse files Browse the repository at this point in the history
Forgot to modify the signatures on the interface when I updated the base
class. This is now fixed.
  • Loading branch information
RomainMuller authored Feb 21, 2019
1 parent cc0a28c commit 4d8419b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/@aws-cdk/aws-sns/lib/topic-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export interface ITopic extends
/**
* Subscribe some endpoint to this topic
*/
subscribe(name: string, endpoint: string, protocol: SubscriptionProtocol): Subscription;
subscribe(name: string, endpoint: string, protocol: SubscriptionProtocol, rawMessageDelivery?: boolean): Subscription;

/**
* Defines a subscription from this SNS topic to an SQS queue.
Expand All @@ -38,8 +38,9 @@ export interface ITopic extends
*
* @param name The subscription name
* @param queue The target queue
* @param rawMessageDelivery Enable raw message delivery
*/
subscribeQueue(queue: sqs.IQueue): Subscription;
subscribeQueue(queue: sqs.IQueue, rawMessageDelivery?: boolean): Subscription;

/**
* Defines a subscription from this SNS Topic to a Lambda function.
Expand All @@ -66,8 +67,9 @@ export interface ITopic extends
*
* @param name A name for the subscription
* @param url The URL to invoke
* @param rawMessageDelivery Enable raw message delivery
*/
subscribeUrl(name: string, url: string): Subscription;
subscribeUrl(name: string, url: string, rawMessageDelivery?: boolean): Subscription;

/**
* Adds a statement to the IAM resource policy associated with this topic.
Expand Down

0 comments on commit 4d8419b

Please sign in to comment.