Skip to content

Commit

Permalink
feat(pkglint): Make sure .snk files are ignored (#1049)
Browse files Browse the repository at this point in the history
Adds a `pkglint` rule to enforce presence of the `*.snk` pattern in both the `.gitignore`
and `.npmignore` file as a way to make it harder for one to accidentially push the
material to public locations.

This was missed in #643.
  • Loading branch information
RomainMuller authored Oct 31, 2018
1 parent cb490be commit 53c8d76
Show file tree
Hide file tree
Showing 185 changed files with 375 additions and 96 deletions.
3 changes: 2 additions & 1 deletion examples/cdk-examples-typescript/.gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
.LAST_BUILD
.LAST_BUILD
*.snk
3 changes: 2 additions & 1 deletion examples/cdk-examples-typescript/.npmignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@

.LAST_BUILD
.LAST_BUILD
*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/applet-js/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/applet-js/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ coverage

dist
.LAST_PACKAGE
.LAST_BUILD
.LAST_BUILD
*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/assert/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/assert/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ coverage

dist
.LAST_PACKAGE
.LAST_BUILD
.LAST_BUILD
*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/assets/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ coverage
.jsii

.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/assets/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-amazonmq/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ coverage
dist
tsconfig.json
tslint.json

*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-amazonmq/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ dist
.LAST_BUILD
.LAST_PACKAGE
.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-apigateway/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-apigateway/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-applicationautoscaling/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-applicationautoscaling/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-appsync/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-appsync/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-athena/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-athena/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-autoscaling/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-autoscaling/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-autoscalingplans/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-autoscalingplans/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-batch/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-batch/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-budgets/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-budgets/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-certificatemanager/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-certificatemanager/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloud9/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-cloud9/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloudformation/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ lib/generated/resources.ts
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-cloudformation/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloudfront/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ coverage

.LAST_BUILD
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-cloudfront/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ coverage

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloudtrail/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-cloudtrail/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-cloudwatch/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ lib/generated/resources.ts
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-cloudwatch/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-codebuild/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ lib/generated/resources.ts
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-codebuild/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-codecommit/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ tslint.json
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-codecommit/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-codedeploy-api/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-codedeploy-api/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-codedeploy/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dist
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-codedeploy/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-codepipeline-api/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ lib/generated/resources.ts
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-codepipeline-api/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-codepipeline/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ lib/generated/resources.ts
.nyc_output
coverage
.nycrc
.LAST_PACKAGE
.LAST_PACKAGE
*.snk
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-codepipeline/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ dist

# Include .jsii
!.jsii

*.snk
Loading

0 comments on commit 53c8d76

Please sign in to comment.