feat(pkglint): Make sure .snk files are ignored (#1049)

Adds a `pkglint` rule to enforce presence of the `*.snk` pattern in both the `.gitignore` and `.npmignore` file as a way to make it harder for one to accidentially push the material to public locations. This was missed in #643.
aws · Oct 31, 2018 · 53c8d76 · 53c8d76
1 parent cb490be
commit 53c8d76
Show file tree

Hide file tree

Showing 185 changed files with 375 additions and 96 deletions.
diff --git a/examples/cdk-examples-typescript/.gitignore b/examples/cdk-examples-typescript/.gitignore
@@ -1 +1,2 @@
-.LAST_BUILD
+.LAST_BUILD
+*.snk
diff --git a/examples/cdk-examples-typescript/.npmignore b/examples/cdk-examples-typescript/.npmignore
@@ -1,2 +1,3 @@
 
-.LAST_BUILD
+.LAST_BUILD
+*.snk
diff --git a/packages/@aws-cdk/applet-js/.gitignore b/packages/@aws-cdk/applet-js/.gitignore
@@ -8,4 +8,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/applet-js/.npmignore b/packages/@aws-cdk/applet-js/.npmignore
@@ -7,4 +7,5 @@ coverage
 
 dist
 .LAST_PACKAGE
-.LAST_BUILD
+.LAST_BUILD
+*.snk
diff --git a/packages/@aws-cdk/assert/.gitignore b/packages/@aws-cdk/assert/.gitignore
@@ -8,4 +8,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/assert/.npmignore b/packages/@aws-cdk/assert/.npmignore
@@ -7,4 +7,5 @@ coverage
 
 dist
 .LAST_PACKAGE
-.LAST_BUILD
+.LAST_BUILD
+*.snk
diff --git a/packages/@aws-cdk/assets/.gitignore b/packages/@aws-cdk/assets/.gitignore
@@ -13,4 +13,5 @@ coverage
 .jsii
 
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/assets/.npmignore b/packages/@aws-cdk/assets/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-amazonmq/.gitignore b/packages/@aws-cdk/aws-amazonmq/.gitignore
@@ -11,3 +11,5 @@ coverage
 dist
 tsconfig.json
 tslint.json
+
+*.snk
diff --git a/packages/@aws-cdk/aws-amazonmq/.npmignore b/packages/@aws-cdk/aws-amazonmq/.npmignore
@@ -14,3 +14,5 @@ dist
 .LAST_BUILD
 .LAST_PACKAGE
 .jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-apigateway/.gitignore b/packages/@aws-cdk/aws-apigateway/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-apigateway/.npmignore b/packages/@aws-cdk/aws-apigateway/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-applicationautoscaling/.gitignore b/packages/@aws-cdk/aws-applicationautoscaling/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-applicationautoscaling/.npmignore b/packages/@aws-cdk/aws-applicationautoscaling/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-appsync/.gitignore b/packages/@aws-cdk/aws-appsync/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-appsync/.npmignore b/packages/@aws-cdk/aws-appsync/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-athena/.gitignore b/packages/@aws-cdk/aws-athena/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-athena/.npmignore b/packages/@aws-cdk/aws-athena/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-autoscaling/.gitignore b/packages/@aws-cdk/aws-autoscaling/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-autoscaling/.npmignore b/packages/@aws-cdk/aws-autoscaling/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-autoscalingplans/.gitignore b/packages/@aws-cdk/aws-autoscalingplans/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-autoscalingplans/.npmignore b/packages/@aws-cdk/aws-autoscalingplans/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-batch/.gitignore b/packages/@aws-cdk/aws-batch/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-batch/.npmignore b/packages/@aws-cdk/aws-batch/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-budgets/.gitignore b/packages/@aws-cdk/aws-budgets/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-budgets/.npmignore b/packages/@aws-cdk/aws-budgets/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-certificatemanager/.gitignore b/packages/@aws-cdk/aws-certificatemanager/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-certificatemanager/.npmignore b/packages/@aws-cdk/aws-certificatemanager/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-cloud9/.gitignore b/packages/@aws-cdk/aws-cloud9/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-cloud9/.npmignore b/packages/@aws-cdk/aws-cloud9/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudformation/.gitignore b/packages/@aws-cdk/aws-cloudformation/.gitignore
@@ -12,4 +12,5 @@ lib/generated/resources.ts
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudformation/.npmignore b/packages/@aws-cdk/aws-cloudformation/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudfront/.gitignore b/packages/@aws-cdk/aws-cloudfront/.gitignore
@@ -11,4 +11,5 @@ coverage
 
 .LAST_BUILD
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudfront/.npmignore b/packages/@aws-cdk/aws-cloudfront/.npmignore
@@ -13,3 +13,5 @@ coverage
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudtrail/.gitignore b/packages/@aws-cdk/aws-cloudtrail/.gitignore
@@ -11,4 +11,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudtrail/.npmignore b/packages/@aws-cdk/aws-cloudtrail/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudwatch/.gitignore b/packages/@aws-cdk/aws-cloudwatch/.gitignore
@@ -13,4 +13,5 @@ lib/generated/resources.ts
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-cloudwatch/.npmignore b/packages/@aws-cdk/aws-cloudwatch/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-codebuild/.gitignore b/packages/@aws-cdk/aws-codebuild/.gitignore
@@ -12,4 +12,5 @@ lib/generated/resources.ts
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-codebuild/.npmignore b/packages/@aws-cdk/aws-codebuild/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-codecommit/.gitignore b/packages/@aws-cdk/aws-codecommit/.gitignore
@@ -12,4 +12,5 @@ tslint.json
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-codecommit/.npmignore b/packages/@aws-cdk/aws-codecommit/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-codedeploy-api/.gitignore b/packages/@aws-cdk/aws-codedeploy-api/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-codedeploy-api/.npmignore b/packages/@aws-cdk/aws-codedeploy-api/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-codedeploy/.gitignore b/packages/@aws-cdk/aws-codedeploy/.gitignore
@@ -12,4 +12,5 @@ dist
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-codedeploy/.npmignore b/packages/@aws-cdk/aws-codedeploy/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-codepipeline-api/.gitignore b/packages/@aws-cdk/aws-codepipeline-api/.gitignore
@@ -13,4 +13,5 @@ lib/generated/resources.ts
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-codepipeline-api/.npmignore b/packages/@aws-cdk/aws-codepipeline-api/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
diff --git a/packages/@aws-cdk/aws-codepipeline/.gitignore b/packages/@aws-cdk/aws-codepipeline/.gitignore
@@ -13,4 +13,5 @@ lib/generated/resources.ts
 .nyc_output
 coverage
 .nycrc
-.LAST_PACKAGE
+.LAST_PACKAGE
+*.snk
diff --git a/packages/@aws-cdk/aws-codepipeline/.npmignore b/packages/@aws-cdk/aws-codepipeline/.npmignore
@@ -12,3 +12,5 @@ dist
 
 # Include .jsii
 !.jsii
+
+*.snk
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,4 +13,5 @@ coverage @@
     .jsii
     .nycrc
-    .LAST_PACKAGE
+    .LAST_PACKAGE
+    *.snk
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,3 +13,5 @@ coverage

		# Include .jsii
		!.jsii

		*.snk